Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the dynaconf transalation for ipv4 to ipv6 #16635

Closed
wants to merge 1 commit into from
Closed

fixed the dynaconf transalation for ipv4 to ipv6 #16635

wants to merge 1 commit into from

Conversation

omkarkhatavkar
Copy link

Problem Statement

all_settings = settings.loaded_by_loaders.items() Retrieves the settings as expressions or raw values, rather than the evaluated values after any transformations or processing have been applied. This causing the hostnames are not getting overridden while it is passed as references.

Solution

simplifying the solution, working on the settings object directly to update the ipv4 to ipv6 translation

Related Issues

@omkarkhatavkar omkarkhatavkar requested a review from a team as a code owner October 10, 2024 07:35
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 10, 2024
@omkarkhatavkar omkarkhatavkar force-pushed the fix_ipv4_ipv6_translation branch from 2f22d03 to b4fdf82 Compare October 10, 2024 07:39
@shweta83
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_registration
network_type: ipv6

@omkarkhatavkar omkarkhatavkar marked this pull request as draft October 10, 2024 07:46
@omkarkhatavkar omkarkhatavkar force-pushed the fix_ipv4_ipv6_translation branch from b4fdf82 to e9cd808 Compare October 10, 2024 08:05
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_registration
network_type: ipv6

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 10, 2024
@omkarkhatavkar omkarkhatavkar force-pushed the fix_ipv4_ipv6_translation branch from e9cd808 to e795fd0 Compare October 10, 2024 08:25
@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_registration
network_type: ipv6

@omkarkhatavkar
Copy link
Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py -k test_positive_update_packages_registration

@omkarkhatavkar
Copy link
Author

This will need more time for testing. for now I will closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare Awaiting requested review from jyejare

@shweta83 shweta83 Awaiting requested review from shweta83

Assignees

@omkarkhatavkar omkarkhatavkar

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omkarkhatavkar @shweta83 @Satellite-QE